Buffer.isBuffer() returns explicit true/false, fixed for non-Uint8Array buffer

diff --git a/index.js b/index.js
index c77d54a0ce1efdc47a8db370117c770e2032f637..7124b1a3bd2fa75723cdd131d3084c2fc55f6ee7 100644 (file)
--- a/index.js
+++ b/index.js
@@ -77,6 +77,7 @@ function Buffer (subject, encoding, noZero) {
     // Fallback: Return this instance of Buffer
     buf = this
     buf.length = length
+    buf._isBuffer = true
   }
 
   var i
@@ -121,7 +122,7 @@ Buffer.isEncoding = function (encoding) {
 }
 
 Buffer.isBuffer = function (b) {
-  return b && b._isBuffer
+  return (b != null && b._isBuffer) || false
 }
 
 Buffer.byteLength = function (str, encoding) {

diff --git a/test/is-buffer.js b/test/is-buffer.js
new file mode 100644 (file)
index 0000000..eec918f
--- /dev/null
+++ b/test/is-buffer.js
@@ -0,0 +1,10 @@
+var B = require('../index.js').Buffer
+var test = require('tape')
+
+test('Buffer.isBuffer', function (t) {
+  t.plan(3)
+  t.equal(B.isBuffer(new B('hey', 'utf8')), true)
+  t.equal(B.isBuffer(new B([1, 2, 3], 'utf8')), true)
+  t.equal(B.isBuffer('hey'), false)
+  t.end()
+})