Allow creating buffers from buffers

diff --git a/index.js b/index.js
index 522dd9358a2c671bedc1e35b35294d30d4b00b47..894532c85c0b9ac71e99e81f6fa48a4073d2e3e0 100644 (file)
--- a/index.js
+++ b/index.js
@@ -359,7 +359,12 @@ function Buffer(subject, encoding, offset) {
     // Treat array-ish objects as a byte array.
     if (isArrayIsh(subject)) {
       for (var i = 0; i < this.length; i++) {
-        this.parent[i + this.offset] = subject[i];
+        if (subject instanceof Buffer) {
+          this.parent[i + this.offset] = subject.readUInt8(i);
+        }
+        else {
+          this.parent[i + this.offset] = subject[i];
+        }
       }
     } else if (type == 'string') {
       // We are a string

diff --git a/test/buffer.js b/test/buffer.js
index f54c5d2508466db4c27a423ac72c8faa073c8059..2cac5d2e7764ae76a54de440a7925ab26d3ccd71 100644 (file)
--- a/test/buffer.js
+++ b/test/buffer.js
@@ -119,3 +119,11 @@ test("concat() a varying number of buffers", function (t) {
     t.equal(flatLongLen.toString(), (new Array(10+1).join('asdf')));
     t.end();
 });
+
+test("buffer from buffer", function (t) {
+    t.plan(1);
+    var b1 = new buffer.Buffer('asdf');
+    var b2 = new buffer.Buffer(b1);
+    t.equal(b1.toString('hex'), b2.toString('hex'));
+    t.end();
+});