Fix #16. TypeError: buf.set is not a function (firefox)

diff --git a/index.js b/index.js
index 91cd518640a0df17f8fbb5aedcc502b607cb8b1b..6c30b3132c3abcfeea61e8d26862d430e1aae77d 100644 (file)
--- a/index.js
+++ b/index.js
@@ -81,7 +81,8 @@ function Buffer (subject, encoding, noZero) {
   }
 
   var i
-  if (typeof Uint8Array === 'function' && subject instanceof Uint8Array) {
+  if (Buffer._useTypedArrays && typeof Uint8Array === 'function' &&
+      subject instanceof Uint8Array) {
     // Speed optimization -- use set if we're copying from a Uint8Array
     buf.set(subject)
   } else if (isArrayish(subject)) {

diff --git a/test/buffer.js b/test/buffer.js
index a449879db1c315ee057c93c1fe2d7867318777bd..7e700e454a5f0b239a54cfd88966cfb03f88ec6f 100644 (file)
--- a/test/buffer.js
+++ b/test/buffer.js
@@ -205,6 +205,19 @@ test("new buffer from buffer", function (t) {
   t.end()
 })
 
+test("new buffer from uint8array", function (t) {
+  if (typeof Uint8Array === 'function') {
+    var b1 = new Uint8Array([0, 1, 2, 3])
+    var b2 = new B(b1)
+    t.equal(b1[0], 0)
+    t.equal(b1[1], 1)
+    t.equal(b1[2], 2)
+    t.equal(b1[3], 3)
+    t.equal(b1[4], undefined)
+  }
+  t.end()
+})
+
 test("fill", function(t) {
   t.plan(1)
   var b = new B(10)