Fix optional parameter typing in overloaded functions. Fix dependency in package...

diff --git a/package-lock.json b/package-lock.json
index 0b8d14ff0d59468aaca0b43d8e75b9bc4a29f7f6..63c2227e3192d2fbdfe9aa493318778de0eacf8c 100644 (file)
--- a/package-lock.json
+++ b/package-lock.json
@@ -9,7 +9,6 @@
                        "version": "0.0.1",
                        "license": "(GPL-3.0-or-later AND MIT)",
                        "dependencies": {
-                               "@ledgerhq/hw-transport-webusb": "6.29.4",
                                "blakejs": "^1.2.1"
                        },
                        "devDependencies": {

diff --git a/src/lib/wallet.ts b/src/lib/wallet.ts
index f998a5a8c45cb861f165e95de9b11f5772717797..7a7ae26b896c6281377b86e609df398ad9b52c1a 100644 (file)
--- a/src/lib/wallet.ts
+++ b/src/lib/wallet.ts
@@ -253,7 +253,7 @@ export class Bip44Wallet extends Wallet {
        * @param {string} [salt=''] - Used when generating the final seed\r
        * @returns {Bip44Wallet} A newly instantiated Bip44Wallet\r
        */\r
-       static async create (password: string, salt: string): Promise<Bip44Wallet>\r
+       static async create (password: string, salt?: string): Promise<Bip44Wallet>\r
        /**\r
        * Creates a new HD wallet by using an entropy value generated using a\r
        * cryptographically strong pseudorandom number generator.\r
@@ -262,7 +262,7 @@ export class Bip44Wallet extends Wallet {
        * @param {string} [salt=''] - Used when generating the final seed\r
        * @returns {Bip44Wallet} A newly instantiated Bip44Wallet\r
        */\r
-       static async create (key: CryptoKey, salt: string): Promise<Bip44Wallet>\r
+       static async create (key: CryptoKey, salt?: string): Promise<Bip44Wallet>\r
        static async create (passkey: string | CryptoKey, salt: string = ''): Promise<Bip44Wallet> {\r
                Bip44Wallet.#isInternal = true\r
                try {\r
@@ -282,7 +282,7 @@ export class Bip44Wallet extends Wallet {
        * @param {string} [salt=''] - Used when generating the final seed\r
        * @returns {Bip44Wallet} A newly instantiated Bip44Wallet\r
        */\r
-       static async fromEntropy (password: string, entropy: string, salt: string): Promise<Bip44Wallet>\r
+       static async fromEntropy (password: string, entropy: string, salt?: string): Promise<Bip44Wallet>\r
        /**\r
        * Creates a new HD wallet by using a pregenerated entropy value. The user\r
        * must ensure that it is cryptographically strongly random.\r
@@ -292,7 +292,7 @@ export class Bip44Wallet extends Wallet {
        * @param {string} [salt=''] - Used when generating the final seed\r
        * @returns {Bip44Wallet} A newly instantiated Bip44Wallet\r
        */\r
-       static async fromEntropy (key: CryptoKey, entropy: string, salt: string): Promise<Bip44Wallet>\r
+       static async fromEntropy (key: CryptoKey, entropy: string, salt?: string): Promise<Bip44Wallet>\r
        static async fromEntropy (passkey: string | CryptoKey, entropy: string, salt: string = ''): Promise<Bip44Wallet> {\r
                Bip44Wallet.#isInternal = true\r
                try {\r
@@ -315,7 +315,7 @@ export class Bip44Wallet extends Wallet {
        * @param {string} [salt=''] - Used when generating the final seed\r
        * @returns {Bip44Wallet} A newly instantiated Bip44Wallet\r
        */\r
-       static async fromMnemonic (password: string, mnemonic: string, salt: string): Promise<Bip44Wallet>\r
+       static async fromMnemonic (password: string, mnemonic: string, salt?: string): Promise<Bip44Wallet>\r
        /**\r
        * Creates a new HD wallet by using a pregenerated mnemonic phrase.\r
        *\r
@@ -324,7 +324,7 @@ export class Bip44Wallet extends Wallet {
        * @param {string} [salt=''] - Used when generating the final seed\r
        * @returns {Bip44Wallet} A newly instantiated Bip44Wallet\r
        */\r
-       static async fromMnemonic (key: CryptoKey, mnemonic: string, salt: string): Promise<Bip44Wallet>\r
+       static async fromMnemonic (key: CryptoKey, mnemonic: string, salt?: string): Promise<Bip44Wallet>\r
        static async fromMnemonic (passkey: string | CryptoKey, mnemonic: string, salt: string = ''): Promise<Bip44Wallet> {\r
                Bip44Wallet.#isInternal = true\r
                try {\r