Add missing binarySlice/binaryWrite methods

diff --git a/index.js b/index.js
index 522dd9358a2c671bedc1e35b35294d30d4b00b47..5ff77ec531e74cc92b3a179350fb2643f26759f5 100644 (file)
--- a/index.js
+++ b/index.js
@@ -49,6 +49,7 @@ SlowBuffer.byteLength = function (str, encoding) {
       return utf8ToBytes(str).length;
 
     case 'ascii':
+    case 'binary':
       return str.length;
 
     case 'base64':
@@ -81,6 +82,8 @@ SlowBuffer.prototype.asciiWrite = function (string, offset, length) {
   return SlowBuffer._charsWritten =  blitBuffer(asciiToBytes(string), this, offset, length);
 };
 
+SlowBuffer.prototype.binaryWrite = SlowBuffer.prototype.asciiWrite;
+
 SlowBuffer.prototype.base64Write = function (string, offset, length) {
   var bytes, pos;
   return SlowBuffer._charsWritten = blitBuffer(base64ToBytes(string), this, offset, length);
@@ -125,6 +128,8 @@ SlowBuffer.prototype.asciiSlice = function () {
   return ret;
 }
 
+SlowBuffer.prototype.binarySlice = SlowBuffer.prototype.asciiSlice;
+
 SlowBuffer.prototype.inspect = function() {
   var out = [],
       len = this.length;

diff --git a/test/buffer.js b/test/buffer.js
index f54c5d2508466db4c27a423ac72c8faa073c8059..0f8c9dd87c86b9795f3a616fef58e5debd57dc61 100644 (file)
--- a/test/buffer.js
+++ b/test/buffer.js
@@ -19,6 +19,15 @@ test('utf8 buffer to hex', function (t) {
     t.end();
 });
 
+test('utf8 to utf8', function (t) {
+    t.plan(1);
+    t.equal(
+        new buffer.Buffer("öäüõÖÄÜÕ", "utf8").toString("utf8"),
+        new Buffer("öäüõÖÄÜÕ", "utf8").toString("utf8")
+    );
+    t.end();
+});
+
 test('ascii buffer to base64', function (t) {
     t.plan(1);
     t.equal(
@@ -72,6 +81,43 @@ test('hex buffer to ascii', function (t) {
     );
     t.end();
 });
+/*
+test('utf8 to ascii', function (t) {
+    t.plan(1);
+    t.equal(
+        new buffer.Buffer("öäüõÖÄÜÕ", "utf8").toString("ascii"),
+        new Buffer("öäüõÖÄÜÕ", "utf8").toString("ascii")
+    );
+    t.end();
+});
+*/
+
+test('base64 buffer to binary', function (t) {
+    t.plan(1);
+    t.equal(
+        new buffer.Buffer("MTIzNDU2IUAjJCVe", "base64").toString("binary"),
+        new Buffer("MTIzNDU2IUAjJCVe", "base64").toString("binary")
+    );
+    t.end();
+});
+
+test('hex buffer to binary', function (t) {
+    t.plan(1);
+    t.equal(
+        new buffer.Buffer("31323334353621402324255e", "hex").toString("binary"),
+        new Buffer("31323334353621402324255e", "hex").toString("binary")
+    );
+    t.end();
+});
+
+test('utf8 to binary', function (t) {
+    t.plan(1);
+    t.equal(
+        new buffer.Buffer("öäüõÖÄÜÕ", "utf8").toString("binary"),
+        new Buffer("öäüõÖÄÜÕ", "utf8").toString("binary")
+    );
+    t.end();
+});
 
 test("hex of write{Uint,Int}{8,16,32}{LE,BE}", function (t) {
     t.plan(2*(2*2*2+2));