Added tests

Added unit tests and removed unnecessary string conversion.

diff --git a/index.js b/index.js
index 258695d888f007b32a768be655409bc3db35c3dc..522dd9358a2c671bedc1e35b35294d30d4b00b47 100644 (file)
--- a/index.js
+++ b/index.js
@@ -416,10 +416,6 @@ Buffer.concat = function (list, totalLength) {
   var pos = 0;
   for (var i = 0; i < list.length; i++) {
     var buf = list[i];
-    // To deal with string objects
-    if (!Buffer.isBuffer(buf)) {
-      buf = new Buffer(buf);
-    }
     buf.copy(buffer, pos);
     pos += buf.length;
   }

diff --git a/test/buffer.js b/test/buffer.js
index 4486602c6a732c7b5f93563b76749424b9a31eae..f54c5d2508466db4c27a423ac72c8faa073c8059 100644 (file)
--- a/test/buffer.js
+++ b/test/buffer.js
@@ -73,7 +73,7 @@ test('hex buffer to ascii', function (t) {
     t.end();
 });
 
-test("hex of write{Uint,Int}{8,16,32}{LE,BE}", function(t) {
+test("hex of write{Uint,Int}{8,16,32}{LE,BE}", function (t) {
     t.plan(2*(2*2*2+2));
     ["UInt","Int"].forEach(function(x){
         [8,16,32].forEach(function(y){
@@ -99,3 +99,23 @@ test("hex of write{Uint,Int}{8,16,32}{LE,BE}", function(t) {
     });
     t.end();
 });
+
+test("concat() a varying number of buffers", function (t) {
+    t.plan(5);
+    var zero = [];
+    var one  = [ new buffer.Buffer('asdf') ];
+    var long = [];
+    for (var i = 0; i < 10; i++) long.push(new buffer.Buffer('asdf'));
+
+    var flatZero = buffer.Buffer.concat(zero);
+    var flatOne = buffer.Buffer.concat(one);
+    var flatLong = buffer.Buffer.concat(long);
+    var flatLongLen = buffer.Buffer.concat(long, 40);
+
+    t.equal(flatZero.length, 0);
+    t.equal(flatOne.toString(), 'asdf');
+    t.equal(flatOne, one[0]);
+    t.equal(flatLong.toString(), (new Array(10+1).join('asdf')));
+    t.equal(flatLongLen.toString(), (new Array(10+1).join('asdf')));
+    t.end();
+});