Support deprecated `get` and `set` calls

diff --git a/index.js b/index.js
index 6c30b3132c3abcfeea61e8d26862d430e1aae77d..dc3a534fc95a0cf0791f082fd32208cc2a208a28 100644 (file)
--- a/index.js
+++ b/index.js
@@ -84,7 +84,7 @@ function Buffer (subject, encoding, noZero) {
   if (Buffer._useTypedArrays && typeof Uint8Array === 'function' &&
       subject instanceof Uint8Array) {
     // Speed optimization -- use set if we're copying from a Uint8Array
-    buf.set(subject)
+    Uint8Array.prototype.set.call(buf, subject)
   } else if (isArrayish(subject)) {
     // Treat array-ish objects as a byte array
     for (i = 0; i < length; i++) {
@@ -401,6 +401,18 @@ Buffer.prototype.slice = function (start, end) {
   }
 }
 
+// `get` will be removed in Node 0.13+
+Buffer.prototype.get = function (offset) {
+  console.log('.get() is deprecated. Access using array indexes instead.')
+  return this.readUInt8(offset)
+}
+
+// `set` will be removed in Node 0.13+
+Buffer.prototype.set = function (v, offset) {
+  console.log('.set() is deprecated. Access using array indexes instead.')
+  return this.writeUInt8(v, offset)
+}
+
 Buffer.prototype.readUInt8 = function (offset, noAssert) {
   var buf = this
   if (!noAssert) {
@@ -839,10 +851,15 @@ function stringtrim (str) {
 
 var BP = Buffer.prototype
 
+/**
+ * Augment the Uint8Array *instance* (not the class!) with Buffer methods
+ */
 function augment (arr) {
   arr._isBuffer = true
 
-  // Augment the Uint8Array *instance* (not the class!) with Buffer methods
+  arr.get = BP.get // deprecated
+  arr.set = BP.set // deprecated
+
   arr.write = BP.write
   arr.toString = BP.toString
   arr.toLocaleString = BP.toString

diff --git a/test/deprecated.js b/test/deprecated.js
new file mode 100644 (file)
index 0000000..dfc1374
--- /dev/null
+++ b/test/deprecated.js
@@ -0,0 +1,18 @@
+var B = require('../index.js').Buffer
+var test = require('tape')
+
+test('.get (deprecated)', function (t) {
+  var b = new B([7, 42])
+  t.equal(b.get(0), 7)
+  t.equal(b.get(1), 42)
+  t.end()
+})
+
+test('.set (deprecated)', function (t) {
+  var b = new B(2)
+  b.set(7, 0)
+  b.set(42, 1)
+  t.equal(b[0], 7)
+  t.equal(b[1], 42)
+  t.end()
+})
\ No newline at end of file