From: Ruben Verborgh <ruben@verborgh.org>
Date: Thu, 12 Dec 2013 18:42:06 +0000 (+0000)
Subject: Access buffer elements directly when slicing.
X-Git-Url: https://zoso.dev/?a=commitdiff_plain;h=6cea608a476bd13c30a7c14d54ae881313393964;p=buffer.git

Access buffer elements directly when slicing.
---

diff --git a/index.js b/index.js
index 133d967..c1b9992 100644
--- a/index.js
+++ b/index.js
@@ -363,29 +363,28 @@ function _base64Slice (buf, start, end) {
 }
 
 function _utf8Slice (buf, start, end) {
-  var bytes = buf.slice(start, end)
   var res = ''
   var tmp = ''
-  var i = 0
-  while (i < bytes.length) {
-    if (bytes[i] <= 0x7F) {
-      res += decodeUtf8Char(tmp) + String.fromCharCode(bytes[i])
+  end = Math.min(buf.length, end);
+
+  for (var i = start; i < end; i++) {
+    if (buf[i] <= 0x7F) {
+      res += decodeUtf8Char(tmp) + String.fromCharCode(buf[i])
       tmp = ''
     } else {
-      tmp += '%' + bytes[i].toString(16)
+      tmp += '%' + buf[i].toString(16)
     }
-
-    i++
   }
 
   return res + decodeUtf8Char(tmp)
 }
 
 function _asciiSlice (buf, start, end) {
-  var bytes = buf.slice(start, end)
   var ret = ''
-  for (var i = 0; i < bytes.length; i++)
-    ret += String.fromCharCode(bytes[i])
+  end = Math.min(buf.length, end);
+
+  for (var i = start; i < end; i++)
+    ret += String.fromCharCode(buf[i])
   return ret
 }