From: Feross Aboukhadijeh <feross@feross.org>
Date: Wed, 1 Jan 2014 02:30:36 +0000 (-0800)
Subject: Only test for slice() parent tracking in supported browsers
X-Git-Url: https://zoso.dev/?a=commitdiff_plain;h=f0d698e93f2c9a3d0d46fc1a1440800d9d4e77a4;p=buffer.git

Only test for slice() parent tracking in supported browsers
---

diff --git a/index.js b/index.js
index b39a624..f8ce472 100644
--- a/index.js
+++ b/index.js
@@ -7,11 +7,11 @@ exports.INSPECT_MAX_BYTES = 50
 Buffer.poolSize = 8192
 
 /**
- * If `browserSupport`:
+ * If `Buffer._useTypedArrays`:
  *   === true    Use Uint8Array implementation (fastest)
  *   === false   Use Object implementation (compatible down to IE6)
  */
-var browserSupport = (function () {
+Buffer._useTypedArrays = (function () {
    // Detect if browser supports Typed Arrays. Supported browsers are IE 10+,
    // Firefox 4+, Chrome 7+, Safari 5.1+, Opera 11.6+, iOS 4.2+.
    if (typeof Uint8Array === 'undefined' || typeof ArrayBuffer === 'undefined')
@@ -70,7 +70,7 @@ function Buffer (subject, encoding, noZero) {
     throw new Error('First argument needs to be a number, array or string.')
 
   var buf
-  if (browserSupport) {
+  if (Buffer._useTypedArrays) {
     // Preferred: Return an augmented `Uint8Array` instance for best performance
     buf = augment(new Uint8Array(length))
   } else {
@@ -93,7 +93,7 @@ function Buffer (subject, encoding, noZero) {
     }
   } else if (type === 'string') {
     buf.write(subject, 0, encoding)
-  } else if (type === 'number' && !browserSupport && !noZero) {
+  } else if (type === 'number' && !Buffer._useTypedArrays && !noZero) {
     for (i = 0; i < length; i++) {
       buf[i] = 0
     }
@@ -387,7 +387,7 @@ Buffer.prototype.slice = function (start, end) {
   start = clamp(start, len, 0)
   end = clamp(end, len, len)
 
-  if (browserSupport) {
+  if (Buffer._useTypedArrays) {
     return augment(this.subarray(start, end))
   } else {
     var sliceLen = end - start
diff --git a/test/slice.js b/test/slice.js
index 2959911..c23a3b1 100644
--- a/test/slice.js
+++ b/test/slice.js
@@ -2,6 +2,8 @@ var B = require('../index.js').Buffer
 var test = require('tape')
 
 test('modifying buffer created by .slice() modifies original memory', function (t) {
+  if (!B._useTypedArrays) return t.end()
+
   var buf1 = new Buffer(26)
   for (var i = 0 ; i < 26 ; i++) {
     buf1[i] = i + 97 // 97 is ASCII a
@@ -17,6 +19,8 @@ test('modifying buffer created by .slice() modifies original memory', function (
 })
 
 test('modifying parent buffer modifies .slice() buffer\'s memory', function (t) {
+  if (!B._useTypedArrays) return t.end()
+
   var buf1 = new Buffer(26)
   for (var i = 0 ; i < 26 ; i++) {
     buf1[i] = i + 97 // 97 is ASCII a