From 174de850ef640433b6b69a890ce5a558f1518d59 Mon Sep 17 00:00:00 2001 From: Feross Aboukhadijeh Date: Thu, 15 Feb 2018 23:35:33 -0800 Subject: [PATCH] skip irrelevant test file: test-buffer-sharedarraybuffer.js --- bin/download-node-tests.js | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/bin/download-node-tests.js b/bin/download-node-tests.js index 48c11e9..6523288 100755 --- a/bin/download-node-tests.js +++ b/bin/download-node-tests.js @@ -38,11 +38,18 @@ function downloadBufferTests (dir, files) { files.forEach(function (file) { if (!/test-buffer.*/.test(file.name)) return - if (file.name === 'test-buffer-fakes.js') { - // These teses only apply to node, where they're calling into C++ and need to - // ensure the prototype can't be faked, or else there will be a segfault. - return - } + const skipFileNames = [ + // Only applies to node. Calls into C++ and needs to ensure the prototype can't + // be faked, or else there will be a segfault. + 'test-buffer-fakes.js', + // This test file is testing the SharedArrayBuffer support, which is obscure + // and now temporarily disabled in all browsers due to the Spectre/Meltdown + // security issue. + 'test-buffer-sharedarraybuffer.js' + ] + + // Skip test files with these names + if (skipFileNames.includes(file.name)) return console.log(file.download_url) -- 2.34.1