From 23aa3937a24222502f93785b8b4e20ee9c7f7f4a Mon Sep 17 00:00:00 2001 From: Feross Aboukhadijeh Date: Wed, 17 Aug 2016 19:28:41 -0700 Subject: [PATCH] test: Remove assert hack Bug in node.js core was fixed in node v6.4.0! https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V6.m d#6.4.0 --- test/node/test-buffer-badhex.js | 41 --------------------------------- 1 file changed, 41 deletions(-) diff --git a/test/node/test-buffer-badhex.js b/test/node/test-buffer-badhex.js index 0b025e9..fd7851d 100644 --- a/test/node/test-buffer-badhex.js +++ b/test/node/test-buffer-badhex.js @@ -5,47 +5,6 @@ var Buffer = require('../../').Buffer; var assert = require('assert'); var Buffer = require('../../').Buffer; -/** - * TEMPORARY HACK UNTIL THIS ASSERT BUG IS FIXED IN NODE CORE - * https://github.com/nodejs/node/issues/8001 - */ -var pToString = function (obj) { return Object.prototype.toString.call(obj) } -var _deepStrictEqual = assert.deepStrictEqual -assert.deepStrictEqual = function (actual, expected, msg) { - if (typeof ArrayBuffer !== 'undefined' && ArrayBuffer.isView(actual) && - ArrayBuffer.isView(expected) && !require('buffer').Buffer.isBuffer(actual) && - !require('buffer').Buffer.isBuffer(expected) && pToString(actual) === pToString(expected) && - !(actual instanceof Float32Array || actual instanceof Float64Array)) { - assert.equal(Buffer.compare(Buffer.from(actual.buffer, - actual.byteOffset, - actual.byteLength), - Buffer.from(expected.buffer, - expected.byteOffset, - expected.byteLength)), 0); - } else { - _deepStrictEqual.call(assert, actual, expected, msg) - } -} -var _deepEqual = assert.deepEqual -assert.deepEqual = function (actual, expected, msg) { - if (typeof ArrayBuffer !== 'undefined' && ArrayBuffer.isView(actual) && - ArrayBuffer.isView(expected) && !require('buffer').Buffer.isBuffer(actual) && - !require('buffer').Buffer.isBuffer(expected) && pToString(actual) === pToString(expected) && - !(actual instanceof Float32Array || actual instanceof Float64Array)) { - assert.ok(Buffer.compare(Buffer.from(actual.buffer, - actual.byteOffset, - actual.byteLength), - Buffer.from(expected.buffer, - expected.byteOffset, - expected.byteLength)) === 0); - } else { - _deepEqual.call(assert, actual, expected, msg) - } -} -/** - * END HACK - */ - // Test hex strings and bad hex strings { var buf1 = Buffer.alloc(4); -- 2.34.1